Skip to content

USHIFT-7168: Bump Go to 1.26#6796

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
pmtk:go1.26/main
Jun 3, 2026
Merged

USHIFT-7168: Bump Go to 1.26#6796
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
pmtk:go1.26/main

Conversation

@pmtk

@pmtk pmtk commented Jun 3, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated RPM build tooling to use Go 1.26 (previously 1.25) with OpenShift 5.0 compatibility
    • Updated development environment to use Go 1.26.3 (previously 1.24.4)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 3, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 3, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@pmtk: This pull request references USHIFT-7168 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8f6c096c-cdc5-4055-af45-62874e69549a

📥 Commits

Reviewing files that changed from the base of the PR and between b7434a8 and 44f92ba.

📒 Files selected for processing (3)
  • Makefile
  • scripts/auto-rebase/rebase_job_entrypoint.sh
  • scripts/devenv-builder/configure-vm.sh

Walkthrough

Go version is upgraded from 1.24.4 to 1.26.3 across build infrastructure. The VM Go installer, rebase entrypoint sed pattern, and Podman RPM builder image tag are all updated to support and use Go 1.26.

Changes

Go 1.26 version promotion

Layer / File(s) Summary
Go version upgrade across build infrastructure
scripts/devenv-builder/configure-vm.sh, scripts/auto-rebase/rebase_job_entrypoint.sh, Makefile		 GO_VER in the VM installation is updated to 1.26.3, the sed pattern for version substitution is corrected from anchored to non-anchored matching, and the RPM builder image tag is changed to rhel-9-golang-1.26-openshift-5.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: bumping Go to version 1.26 across build tooling and VM configuration.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains no Ginkgo tests. Modified files are build configuration (Makefile) and shell scripts (auto-rebase, configure-vm), not test definitions.
Test Structure And Quality ✅ Passed This PR updates Go version and build tooling only (Makefile, shell scripts for VM/rebase automation). No Ginkgo test files are added or modified, so the test quality check is not applicable.
Microshift Test Compatibility ✅ Passed PR only updates Go to 1.26 in build scripts; no new Ginkgo e2e tests added, so check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies build tooling and Go version configuration; no new Ginkgo e2e tests are added.
Topology-Aware Scheduling Compatibility ✅ Passed PR updates Go version and build tooling only (Makefile, rebase scripts, VM configuration). No deployment manifests, operator code, or controllers modified; topology-aware check does not apply.
Ote Binary Stdout Contract ✅ Passed PR changes are limited to Go version updates (1.24.4→1.26.3) and build tooling configuration. No modifications to OTE binary code, main() functions, test setup, or stdout handling present.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only updates Go version (1.24.4→1.26.3) and build tooling; no Ginkgo e2e tests are added, so check is not applicable.
No-Weak-Crypto ✅ Passed PR updates Go version (1.24.4→1.26.3) and build tooling; contains no weak crypto, custom crypto implementations, or insecure secret comparisons.
Container-Privileges ✅ Passed PR modifies Makefile and shell scripts only; contains no K8s manifests or container configurations with privilege escalation settings.
No-Sensitive-Data-In-Logs ✅ Passed PR changes only update Go version numbers and image tags; no logging of passwords, tokens, API keys, PII, or sensitive data is introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@pmtk pmtk mentioned this pull request Jun 3, 2026
Closed
@openshift-ci openshift-ci Bot requested review from agullon and ggiguash June 3, 2026 12:28
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2026
@ggiguash

ggiguash commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2026
@pmtk

pmtk commented Jun 3, 2026

Copy link
Copy Markdown
Member Author

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 3, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 3, 2026

Copy link
Copy Markdown

@pmtk: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pacevedom
pacevedom approved these changes Jun 3, 2026
View reviewed changes

@pacevedom pacevedom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@pacevedom

pacevedom commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ggiguash,pacevedom,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

openshift-merge-bot Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD b7434a8 and 2 for PR HEAD 44f92ba in total

@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 04423a1 into openshift:main Jun 3, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pacevedom pacevedom pacevedom approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@agullon agullon Awaiting requested review from agullon

@ggiguash ggiguash Awaiting requested review from ggiguash

Assignees

@pacevedom pacevedom

@ggiguash ggiguash

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pmtk @openshift-ci-robot @ggiguash @pacevedom